-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FrameListener pullrequest #48
Conversation
added the frame map definition to header, so that a program using libfreenect2 does not have to include the frame listener implementation.
Config is read from the Config struct. Removed unused variables from opencl code.
added a cmake variable for the depends dir.
I would like to keep FrameListener as an interface with a single method |
That is also a solution. As long as the implementation gets hidden everything is fine. |
…OpenKinect#48\n - added non-blocking method to check if all frames are available\n - added timed wait function if compiled with c++0x or c++11
- implementation using pimpl - fixes OpenKinect#48 - added non-blocking method to check if all frames are available - fixes OpenKinect#56 - added timed wait function if compiled with c++0x or c++11
included in PR #57 |
I moved the definition of the FrameMap to the frame_listener.hpp and extended to FrameListener to have prototypes of all needed methods, that are implemented in the actual FrameListener implementation. Also I added a static method for creating a new FrameListener.
With this changes the projects that are using libfreenect2 only have to include the libfreenect2.hpp and the frame_listener.hpp. They do not have to include the frame_listener_impl.h anymore.