-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NMS-15699: Prevent external xml entity loading #6355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another that should go back to foundation-2023
or earlier if possible
1ebe948
to
3c17231
Compare
This was just introduced in 2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming this passes, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@RangerRick @christianpape Do we have a rough idea when this fix will be released? Since the defect was reported by external researchers, they are approaching for a timeframe of the release. Thanks! |
@qunhe it's merged, so it'll be in the normal monthly (2nd Wednesday of the month) release schedule, which means it should go out with the August 9th Meridian 2023 and Horizon 32 builds. (In general, if you see something has been merged, barring complications you can expect it will apply to the branch it was merged to and up, on the next 2nd Wednesday.) |
Readme need to update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade
All Contributors
Contribution Checklist
Once there is an issue, please:
${JIRA-ISSUE-NUMBER}: subject of pull request
Don't worry if this sounds like a lot, we can help you get things set up properly.
-smoke
in it to trigger smoke tests?foundation-*
branch, does it try to avoid changing files in$OPENNMS_HOME/etc/
?What's Next?
A PR should be assigned at least 2 reviewers. If you know that someone would be a good person to review your code, feel free to add them.
If you need help making additions or changes to the documentation related to your changes, please let us know.
In any case, if anything is unclear or you want help getting your PR ready for merge, please don't hesitate to say something in the comments here,
or in the #opennms-development chat channel.
Once reviewer(s) accept the PR and the branch passes continuous integration, the PR is eligible for merge.
At that time, if you have commit access (are an OpenNMS Group employee or a member of the OGP) you are welcome to merge the PR when you're ready.
Otherwise, a reviewer can merge it for you.
Thanks for taking time to contribute!
External References