fix: add validation to prevent duplicated local ports #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmartins-unit
requested changes
Feb 15, 2024
main.go
Outdated
|
|
||
| if err := validateRemotes(args[1:]); err != nil { | ||
| log.Fatal(err) | ||
| } else { |
| func validateRemotes(remotes []string) error { | ||
| uniqueRemotes := []string{} | ||
|
|
||
| for _, newRemote := range remotes { |
There was a problem hiding this comment.
can't we create a list/slice with ports and use the "unique" package and check the size ?
There was a problem hiding this comment.
For future proof scenarios, in case we want to extend the validations, having it behind a method is easier.
bmartins-unit
approved these changes
Feb 15, 2024
dnlopes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue when a duplicated port on the Remote configuration was provided.