-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for several features for the RTF writer #1775
Conversation
Otherwise, colors will not be as expected for RTF and ODT.
1. Converter is currently expecting colors as strings of hex digits, but PhpWord allows specification of colors by named constant, so result is random when one of those is used. This change handles all the named colors. 2. Table needs \pard at end; formatting may be wrong without it. 3. RTF writer will no longer ignore paragraph style for TextRun. 4. RTF writer will no longer ignore paragraph and font style for Title. 5. Add support for RTF headers and footers. 6. Add support for right-to-left in font. 7. Add support for PageBreakBefore and LineHeight for paragraphs. 8. Add support for PageNumberingStart for sections. There are test cases for all of these changes.
Changes to doc-blocks and code suggested by Scrutinizer.
Some more editorial changes.
Fix PHPUnit tests on develop branch
I'm not sure if I need to do something about "resolve conflicts". Tests weren't working because fixes were required to AbstractWebServerEmbeddedTest.php, for which there was a pull request for a change which had not yet been merged, so I borrowed the code from that change. Now that it has been merged, it no longer needs to be part of this change, but I'm not sure how to disentangle it. Please let me know what I should be doing, if anything. |
The best is to have a separate branch per implemented feature. You can of course have your own develop branch with everything merged. |
RTF Changes
but PhpWord allows specification of colors by named constant, so
result is random when one of those is used. This change handles
all the named colors.
There are test cases for all of these changes.
Fixes # (issue)
Checklist:
composer run-script check --timeout=0
and no errors were reportedNo documentation changes required.