Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated warning for non-hexadecimal number #1988

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

Ciki
Copy link
Contributor

@Ciki Ciki commented Dec 22, 2020

Description

I've come across this deprecated warning when trying to save docx to pdf.. if cellBgColor is set to auto it should be converted back to null which has in practice the same functionality.

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

Ciki and others added 3 commits December 22, 2020 12:12
I've come across this deprecated warning when trying to save docx to pdf.. if cellBgColor is set to `auto` it should be converted back to `null` which has in practice the same functionality.
@troosan troosan added this to the v0.18.0 milestone Feb 5, 2021
@troosan troosan merged commit 3c66ce9 into PHPOffice:develop Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants