Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the Options section of the PDF Writer documentation #2642

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

settermjd
Copy link
Contributor

@settermjd settermjd commented Aug 6, 2024

Description

When I used PHPWord to write a PDF document, recently, I followed the relevant docs only to find that I also had to specify a PDF renderer — otherwise the operation failed.

After a bit of research to figure out what to do to specify one, I thought it only right to document what I learned in the official documentation.

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

When I used PHPWord to write a PDF document, recently, I followed the
docs only to find that I also had to specify a PDF renderer — otherwise
the operation failed.

After a bit of research to figure out what to do to specify one, I
thought it only right to document what I learned in the official
documentation.
@coveralls
Copy link

coveralls commented Aug 6, 2024

Coverage Status

coverage: 97.208%. remained the same
when pulling a31c94b on settermjd:update-pdf-rendering-docs
into 2daa50c on PHPOffice:master.

@Progi1984
Copy link
Member

@settermjd Could you update the changelog, please ?

@settermjd
Copy link
Contributor Author

@settermjd Could you update the changelog, please ?

Shall do.

This change updates the changelog to include the enhancement made to the
PDF Writer docs that show how to specify a PDF renderer when working
with the PDF writer.
@settermjd
Copy link
Contributor Author

@settermjd Could you update the changelog, please ?

I believe I've done that, appropriately, now. Please let me know if the change needs to be revised.

Copy link
Member

@Progi1984 Progi1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

docs/changes/2.x/2.0.0.md Outdated Show resolved Hide resolved
@Progi1984 Progi1984 merged commit f9ce804 into PHPOffice:master Aug 7, 2024
13 checks passed
@Progi1984 Progi1984 added this to the 2.0.0 milestone Aug 7, 2024
@Progi1984
Copy link
Member

Thanks @settermjd

@settermjd
Copy link
Contributor Author

Thanks @settermjd

You're most welcome. Thanks for accepting the PR.

@settermjd settermjd deleted the update-pdf-rendering-docs branch August 8, 2024 06:17
@Progi1984
Copy link
Member

@settermjd Just sorry for the Time. Maintainer is a hard job (After the daily job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants