Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all w3c suggestions and errors #251

Closed
talha131 opened this issue Jan 2, 2019 · 1 comment
Closed

Fix all w3c suggestions and errors #251

talha131 opened this issue Jan 2, 2019 · 1 comment
Labels
released
Milestone
2019 - Q3

Comments

@talha131
Copy link
Member

talha131 commented Jan 2, 2019

Related to #152

We want to target 100% compliance. You need to install offline w3c validator.

At the time of writing, following are few of its suggestions

INFO:w3c_validator.validator:validating: archives.html ...
info: line 81: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 88: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 95: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 102: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 110: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 117: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 124: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 131: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 138: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 145: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 152: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 159: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 166: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 173: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 180: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 187: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 194: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 201: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 208: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 216: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 223: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.
info: line 229: Article lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all articles.

INFO:w3c_validator.validator:Files to validate:
  how-does-modified-metadata-works.html
INFO:w3c_validator.validator:Number of files: 1
INFO:w3c_validator.validator:validating: how-does-modified-metadata-works.html ...
info: line 120: Section lacks heading. Consider using “h2”-“h6” elements to add identifying headings to all sections.
@talha131 talha131 added this to the Elegant 3.0 milestone Jan 2, 2019
@iranzo iranzo mentioned this issue Jan 13, 2019
Closed
@talha131 talha131 modified the milestones: Roadmap, 2019 - Q3 Jun 17, 2019
@talha131 talha131 mentioned this issue Jul 5, 2019
Closed
@talha131 talha131 mentioned this issue Jul 31, 2019
Closed
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): remove type and language attributes
b700224 
Update #251
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): remove redundant sections without heading
df9221f 
Update #251
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): remove incorrect usage of article tag
e8231e0 
Update #251
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): remove redundant article tag
d07c27e 
Update #251
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): remove obsolete charset attribute
8deb285 
Update #251
talha131 added a commit that referenced this issue Aug 10, 2019
@talha131
fix(w3c validation): update CSS rules
0b78d46 
fix #251
talha131 pushed a commit that referenced this issue Aug 22, 2019
@semantic-release-bot
chore(release): 4.0.0 [skip ci]
9305978 
# [4.0.0](V3.2.0...V4.0.0) (2019-08-22)

### Bug Fixes

* **admonition:** an artifact in border behind the title ([88113c3](88113c3))
* **admonition:** reduce border radius to match radii of other components ([de08d20](de08d20)), closes [#490](#490)
* **admonition:** remove box shadow ([d059db8](d059db8)), closes [#490](#490)
* **admonition:** remove text-shadow from heading ([1c889da](1c889da)), closes [#490](#490)
* **clean URL:** default URL of categories, tags and archives fails on some servers ([3c7df6a](3c7df6a)), closes [#280](#280) [#276](#276)
* **comments:** W3C validation errors ([76a1f26](76a1f26))
* **disqus:** remove SITEURL condition to show Disqus comments section ([753d5a5](753d5a5))
* **lang:** do not override default value of DEFAULT_LANG set by Pelican ([d6c60c2](d6c60c2))
* **social:** reduce icon sizes in the sidebar ([c769ba3](c769ba3))
* **social:** use nofollow for social links in the sidebar ([50cff87](50cff87))
* **social:** W3C validation error ([ec4521e](ec4521e))
* **table:** reduce border radius to match radii of other components ([7eaaa96](7eaaa96))
* **w3c validation:** remove incorrect usage of article tag ([e8231e0](e8231e0)), closes [#251](#251)
* **w3c validation:** remove obsolete charset attribute ([8deb285](8deb285)), closes [#251](#251)
* **w3c validation:** remove redundant article tag ([d07c27e](d07c27e)), closes [#251](#251)
* **w3c validation:** remove redundant sections without heading ([df9221f](df9221f)), closes [#251](#251)
* **w3c validation:** remove type and language attributes ([b700224](b700224)), closes [#251](#251)
* **w3c validation:** update CSS rules ([0b78d46](0b78d46)), closes [#251](#251)

### Features

* **404:** auto fill search box with URL fragment that was not found ([c0a7f47](c0a7f47))
* **admonition:** add box shadow ([246f826](246f826))
* **admonition:** border color should match the title color ([1adadbe](1adadbe))
* **admonition:** increase contrast of title ([7fb82cc](7fb82cc))
* **admonition:** use svg image instead of font-awesome icon ([e7c4029](e7c4029)), closes [#487](#487)
* **clean url:** support clean URL for search page ([088791e](088791e))
* **comments:** add support for utterances comment system ([a2151cc](a2151cc)), closes [#288](#288)
* **quotes:** improve style and remove font-awesome for quote icon ([9ef3ac8](9ef3ac8)), closes [#487](#487)
* **social:** add icons for 7 more websites ([8dcf8fa](8dcf8fa)), closes [#494](#494)
* **social:** use svg icons instead of font-awesome ([19f458b](19f458b))
* **table:** add style rule to make tables pop out ([6a8500b](6a8500b)), closes [#440](#440)

### Performance Improvements

* **admonition:** add attributes to svg iamges ([a740a60](a740a60))
* **requests:** remove font awesome ([7c20145](7c20145)), closes [#487](#487)

### BREAKING CHANGES

* **requests:** We have removed font awesome. Now we use svg images for all icons. This will result
in one less web request, which in turn will improve your websites performance.
* **social:** Style customization and configuration of social icons
in the sidebar has changed.

New icons have better colors and bigger sizes.
* **clean URL:** To enable clean URLs for tags, categories and archives,
first configure your server to support clean URLs. Then set `TAGS_URL`,
`CATEGORIES_URL` and `ARCHIVES_URL` to `"tags"`, `"categories"` and
`"archives"` respectively.
@talha131
Copy link
Member Author

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Milestone
2019 - Q3
Development

No branches or pull requests
1 participant
@talha131