Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code inside heading should have same size as heading #508

Closed
talha131 opened this issue Sep 15, 2019 · 1 comment
Closed

Code inside heading should have same size as heading #508

talha131 opened this issue Sep 15, 2019 · 1 comment
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Milestone
2019 - Q4

Comments

@talha131
Copy link
Member

Compare both images.

We want what's on the right. It happens because font size in pre is hardcoded. It should inherit the font size from the parent container.
@talha131 talha131 added the bug Well, it shouldn’t be doing that. Let’s fix it! label Sep 15, 2019
@talha131 talha131 added this to the 2019 - Q4 milestone Sep 15, 2019
talha131 added a commit that referenced this issue Dec 1, 2019
@talha131
feat(typography): code inside heading is consistently 80% of the size
7180b49 
Previously code inside heading was too small

fix #508
talha131 pushed a commit that referenced this issue Dec 2, 2019
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
4ee37de 
# [5.0.0](V4.0.0...V5.0.0) (2019-12-02)

### Bug Fixes

* **css:** linter warning ([a5f5c81](a5f5c81))
* **page:** social profiles appear in the sidebar ([c17077c](c17077c)), closes [#534](#534)
* **social:** reduce icon size in the sidebar ([4e0dc41](4e0dc41)), closes [#490](#490)
* **typography:** adjust heading sizes and set small font-style to italic ([d3bbf04](d3bbf04))
* **typography:** remove border from headings in archive page ([817bea8](817bea8))

### Features

* **blockquote:** improve blockquote look ([068d50a](068d50a))
* **border:** change border radius of tags and code blocks to match rest of the theme ([5d0285f](5d0285f)), closes [#521](#521)
* **border:** have consistent border radius ([7307467](7307467)), closes [#521](#521)
* **code-block:** minor refine code-block style ([2ba2232](2ba2232))
* **css:** use PostCSS for processing CSS files ([2b88865](2b88865)), closes [#354](#354)
* **links:** add new style and improve existing style for hyperlinks ([87fd3d3](87fd3d3)), closes [#533](#533) [#519](#519)
* **permalink:** improve permalink look ([8059ca8](8059ca8))
* **security:** use rel="noopener noreferrer" with all target="_blank" ([4c843e9](4c843e9))
* **typography:** code inside heading is consistently 80% of the size ([7180b49](7180b49)), closes [#508](#508)
* **typography:** headings sizes and other properties are consistent ([afa99ab](afa99ab)), closes [#508](#508) [#521](#521)
* **typography:** use darker color for article heading and increase border size ([1922075](1922075))

### BREAKING CHANGES

* **links:** Style of muted links have been changed slightly. It is
still muted but has modern animation.
@talha131
Copy link
Member Author

talha131 commented Dec 2, 2019

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Well, it shouldn’t be doing that. Let’s fix it! released
Milestone
2019 - Q4
Development

No branches or pull requests
1 participant
@talha131