-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZNE local folding #1006
ZNE local folding #1006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add some some pytest parametrization to test the local folding? (global folding python tests)
@WrathfulSpatula I think there are some integration issues between the type in the frontend and the one in MLIR for local folding. |
I did some debugging on this. I double checked all the Enums both in Python and C++ and those are working fine. The situation that raises an error is when the circuit has a parameter. E.g. def circuit(x):
...
qml.RZ(x, wires=0)
... as opposed to def circuit()
... |
Co-authored-by: Romain Moyard <rmoyard@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A changelog entry and add "all" to the Zne function docs and I am happy to approve it 👍
A change log entry has been added, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, thanks a lot great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Left some nits.
It looks like the linter job is still complaining about test_mitigation.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 76 76
Lines 10782 10782
Branches 1251 1251
=======================================
Hits 10527 10527
Misses 205 205
Partials 50 50 ☔ View full report in Codecov by Sentry. |
@WrathfulSpatula Can you update the changelog and merge main. Then I can merge the PR 👍 |
@rmoyard I fixed the changelog indentation. Which build do I check to see if it renders correctly? |
It looks good, in the github action there is a read the docs one you can click on details. Then you see the generated docs. |
**Context:** Unitary Fund has partnered with Xanadu PennyLane Catalyst to add local folding functionality to Catalyst. As discussed previously, the implementation does not yet match the unit test, but we would like to share the content state of progress, for feedback. **Description of the Change:** This is a work-in-progress to add local folding functionality, of all gates in a quantum circuit, to Catalyst, with a unit test. (Local folding of random gates in a circuit will follow, after this PR.) **Benefits:** Local folding, of single quantum gates, is an alternative method to global folding, of the entire circuit effectively as a single overall operator. Certain circuits and quantum computer architectures might benefit more from either method. **Possible Drawbacks:** There are no particular drawbacks to offering an additional option of local folding, along with global folding. **Related GitHub Issues:** #755 --------- Co-authored-by: Alessandro Cosentino <cosenal@gmail.com> Co-authored-by: Romain Moyard <rmoyard@gmail.com>
**Context:** Unitary Fund has partnered with Xanadu PennyLane Catalyst to add local folding functionality to Catalyst. As discussed previously, the implementation does not yet match the unit test, but we would like to share the content state of progress, for feedback. **Description of the Change:** This is a work-in-progress to add local folding functionality, of all gates in a quantum circuit, to Catalyst, with a unit test. (Local folding of random gates in a circuit will follow, after this PR.) **Benefits:** Local folding, of single quantum gates, is an alternative method to global folding, of the entire circuit effectively as a single overall operator. Certain circuits and quantum computer architectures might benefit more from either method. **Possible Drawbacks:** There are no particular drawbacks to offering an additional option of local folding, along with global folding. **Related GitHub Issues:** #755 --------- Co-authored-by: Alessandro Cosentino <cosenal@gmail.com> Co-authored-by: Romain Moyard <rmoyard@gmail.com>
Context:
Unitary Fund has partnered with Xanadu PennyLane Catalyst to add local folding functionality to Catalyst. As discussed previously, the implementation does not yet match the unit test, but we would like to share the content state of progress, for feedback.
Description of the Change:
This is a work-in-progress to add local folding functionality, of all gates in a quantum circuit, to Catalyst, with a unit test. (Local folding of random gates in a circuit will follow, after this PR.)
Benefits:
Local folding, of single quantum gates, is an alternative method to global folding, of the entire circuit effectively as a single overall operator. Certain circuits and quantum computer architectures might benefit more from either method.
Possible Drawbacks:
There are no particular drawbacks to offering an additional option of local folding, along with global folding.
Related GitHub Issues:
#755