Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename folding all to local-all in ZNE #1129

Merged
merged 8 commits into from
Sep 11, 2024
Merged

Rename folding all to local-all in ZNE #1129

merged 8 commits into from
Sep 11, 2024

Conversation

rmoyard
Copy link
Contributor

@rmoyard rmoyard commented Sep 11, 2024 •
edited
Loading

Context:
all and random folding kwarg for mitigate_with_zne do not specify that folding is done locally and it is confusing.

Description of the Change:
all becomes local-all

@rmoyard rmoyard marked this pull request as ready for review September 11, 2024 17:59
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (20bd698) to head (7d3e130).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
- Coverage   99.80%   97.62%   -2.19%     
==========================================
  Files          21       75      +54     
  Lines        4210    10758    +6548     
  Branches      201     1251    +1050     
==========================================
+ Hits         4202    10503    +6301     
- Misses          8      205     +197     
- Partials        0       50      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmoyard rmoyard added this to the v0.8.1 milestone Sep 11, 2024
dime10
dime10 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's better!

@rmoyard rmoyard merged commit d79ac79 into main Sep 11, 2024
41 of 42 checks passed
@rmoyard rmoyard deleted the rename_all branch September 11, 2024 19:32
rauletorresc pushed a commit that referenced this pull request Sep 11, 2024
@rmoyard @rauletorresc
Rename folding all to local-all in ZNE (#1129)
32acd07 
**Context:**
`all` and `random` folding kwarg for `mitigate_with_zne` do not specify
that folding is done locally and it is confusing.

**Description of the Change:**
`all` becomes `local-all`
mehrdad2m pushed a commit that referenced this pull request Sep 17, 2024
@rmoyard @mehrdad2m
Rename folding all to local-all in ZNE (#1129)
0a741c7 
**Context:**
`all` and `random` folding kwarg for `mitigate_with_zne` do not specify
that folding is done locally and it is confusing.

**Description of the Change:**
`all` becomes `local-all`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

@erick-xanadu erick-xanadu erick-xanadu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rmoyard @dime10 @erick-xanadu