[Runtime][Frontend] Add support for custom QuantumDevices. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
force-pushed
the
eochoa/2023-10-17/loading
branch
from
9e34108
to
a1e0be2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 41 42 +1
Lines 7353 7404 +51
Branches 430 432 +2
=======================================
+ Hits 7321 7372 +51
Misses 16 16
Partials 16 16
☔ View full report in Codecov by Sentry. |
erick-xanadu
force-pushed
the
eochoa/2023-10-17/loading
branch
from
e91fb9d
to
de55ac9
Compare
Custom devices which implement the `QuantumDevice` class must also
implement an
```cpp
extern "C" Catalyst::Runtime::QuantumDevice*
getCustomDevice() { return new CustomDevice(); }
```
PennyLane plugin devices should also implement
```python
@staticmethod
def get_c_interface():
return path_to_shared_lib
```
Then the following works:
```python
@qjit
@qml.qnode(qml.device("custom.device", wires=wires))
def circuit():
...
```
See this error message: You are trying to dlopen a this-file-does-not-exist.so shared library with RTLD_DEEPBIND flag which is incompatible with sanitizer runtime (see google/sanitizers#611 for details). If you want to run this-file-does-not-exist.so library under sanitizers please remove RTLD_DEEPBIND from dlopen flags.
This reverts commit 854f7f0.
maliasadi
reviewed
Oct 24, 2023
Co-authored-by: Ali Asadi <ali@xanadu.ai>
Co-authored-by: Ali Asadi <ali@xanadu.ai>
maliasadi
reviewed
Oct 24, 2023
…talyst into eochoa/2023-10-17/loading
maliasadi
reviewed
Oct 24, 2023
maliasadi
reviewed
Oct 24, 2023
maliasadi
approved these changes
Oct 24, 2023
josh146
approved these changes
Oct 24, 2023
maliasadi
reviewed
Oct 24, 2023
Co-authored-by: David Ittah <dime10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Changes needed to support third party devices.
Third party devices must implement the
Catalyst::Runtime::QuantumDeviceinterface and add agetCustomDevicemethod which returns an instance of their device.PennyLane plugin devices should also implement
Then the following works:
Description of the Change: Changes in the frontend to allow any devices that implement a
QuantumDeviceinterface to be loaded into the runtime. Changes to the runtime as well.Benefits: Third party developers can implement their own devices as long as they follow the spec.
Possible Drawbacks: Benchmarks showed no impact.
Related GitHub Issues:
Note:
RTLD_DEEPBINDis needed for allowing custom QuantumDevices to work. However,RTLD_DEEPBINDis incompatible with sanitizers.[sc-46413]