Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLIR] Improve the compiler driver failure reporting #349

Merged
merged 6 commits into from
Nov 2, 2023
Merged

[MLIR] Improve the compiler driver failure reporting #349

merged 6 commits into from
Nov 2, 2023

Conversation

sergei-mironov
Copy link
Contributor

@sergei-mironov sergei-mironov commented Nov 2, 2023 •
edited
Loading

In this PR we add the following functionality to the CompilerDriver:

  • Print the name of failed pass along with the name of the pipeline
  • Dump the failing IR into the workspace with the "_FAILED" suffix

@sergei-mironov sergei-mironov marked this pull request as ready for review November 2, 2023 13:04
dime10
dime10 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@dime10 dime10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

mlir/lib/Driver/CompilerDriver.cpp Outdated Show resolved Hide resolved
@dime10
Copy link
Collaborator

dime10 commented Nov 2, 2023

Changelog :)

@sergei-mironov sergei-mironov merged commit 6c7919e into main Nov 2, 2023
18 checks passed
@sergei-mironov sergei-mironov deleted the compiler-driver-print-failures branch November 2, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dime10 dime10 dime10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergei-mironov @dime10