-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macros for generating the device entry-point and declarations #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 99.49% 99.49%
=======================================
Files 42 42
Lines 7150 7150
Branches 483 483
=======================================
Hits 7114 7114
Misses 20 20
Partials 16 16 ☔ View full report in Codecov by Sentry. |
dime10
approved these changes
Dec 8, 2023
erick-xanadu
requested changes
Dec 8, 2023
maliasadi
changed the title
Add a templated macro for generating the device entry-points
Add macros for generating the device entry-point and declarations
Dec 11, 2023
erick-xanadu
approved these changes
Dec 11, 2023
dime10
reviewed
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a C++ template macro to facilitate the generation of a device entry-point. For every implementation of
QuantumDevice
, there are a repeated list of methods declarations in the header file of the class. These declarations can be templated away to reduce the redundant code to write a new backend device. This PR addresses this issue with introducing a couple of macros to generate these declarations. It also updates the signature ofextern "C"
factory methods to stick to the C data-types.