-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the new device API #565
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #565 +/- ##
==========================================
+ Coverage 99.48% 99.49% +0.01%
==========================================
Files 50 50
Lines 8683 8740 +57
Branches 616 624 +8
==========================================
+ Hits 8638 8696 +58
Misses 25 25
+ Partials 20 19 -1 ☔ View full report in Codecov by Sentry. |
…AI/catalyst into support_new_device_api
[sc-57856] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rmoyard! My main concern is around the interaction between custom Catalyst operations/restrictions, the TOML specification, and the device pre-processing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Context:
PennyLane recently added a new device API.
Description of the Change:
In this PR we create anothe QJIT device that supports the new device API. Users define preprocessing by adding transforms to the preprocess method.
We can add our own transforms in the QJIT device preprocess function, if necessary.