Fix extension when looking for mlir_c_runner library #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erick-xanadu
added
reviewer:require-wheels
erick-xanadu
force-pushed
the
eochoa/2024-05-08/fix-dylib
branch
from
d771b61
to
171b610
Compare
rmoyard
reviewed
Apr 9, 2024
rmoyard
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: When merging callbacks, something that was an oversight was the extension of shared libraries in different operating systems. In Darwin, the extension is
.dylib. In unix, it is.so.Description of the Change: This commit selects the correct extension based on the operating system that the code is being run.
Benefits: No errors on tests.