Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build-package-images.sh.tmpl #224

Merged
merged 1 commit into from
Jan 26, 2024
Merged

fix build-package-images.sh.tmpl #224

merged 1 commit into from
Jan 26, 2024

Conversation

wuhuizuo
Copy link
Contributor

Avoid kaniko cache issue

Ref: GoogleContainerTools/kaniko#1469

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind January 26, 2024 08:31
Copy link

ti-chi-bot bot commented Jan 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems that the key change is adding the --cache-run-layers option to the kaniko_executor_global_options variable in the build_and_push_images function. This option is meant to avoid a caching issue that was reported in the linked issue (GoogleContainerTools/kaniko#1469).

There don't seem to be any potential problems with this change, as it is a straightforward fix for a known issue. However, it would be helpful to have more context on how this script is being used and what the build process is like, to ensure that this change doesn't have any unforeseen consequences.

As for fixing suggestions, if there are any additional tests or checks that can be added to ensure that this change doesn't cause any issues, those should be considered. Additionally, it might be helpful to update any documentation or README files to reflect this change and explain its purpose.

@ti-chi-bot ti-chi-bot bot added the size/XS label Jan 26, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 26, 2024
Copy link

ti-chi-bot bot commented Jan 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-26 08:32:58.296284148 +0000 UTC m=+1122419.860581854: ☑️ agreed by lijie0123.

@jayl1e jayl1e merged commit cdc09e3 into main Jan 26, 2024
2 checks passed
@jayl1e jayl1e deleted the wuhuizuo-patch-1 branch January 26, 2024 08:35
wuhuizuo added a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants