Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't see anything in the README about how to properly format PRs, please let me know if there's anything you would like me to do to validate this change.
Description
When testing the Github action my extension is not in a publishable state and the action kept failing (I wanted to just upload and not publish). After investigation I realized it was because the
uploadOnly
option was not being assigned tothis.options
in the constructor.This change will still check for required fields but use all passed constructor options. If you'd like it to be more specific to only allow defined options I'm happy to make that change as well.