Fixed many bugs in BuildBattle plugin

[Waterman1001]

Hi again, I have been working on resolving some bugs within BuildBattle that I found.
The most noticable error is the Menu Item not working when in-game, so it is impossible to open the BuildBattle menu for players.
I found out the reason for this is that BuildBattle uses the MiniGamesBox API at two different places regarding the menu item.

• It registered it as special item using the API in registerSpecialItems() present in AdditionalValueInitializer.java
• It registered it as a separate HandlerItem in getMenuItem() present in BaseArena.java.
  The first use did not provide an InteractHandler to the item (it takes it from the special_items.yml config and this one is empty), while the second use did actually correctly provide an InteractHandler. However, since it was looped through the array of special items and as soon as a matching ItemStack was found, a menu item having no Interact Handler was picked by the loop and therefore the correct item was dismissed, making the menu item not work anymore.

I have changed this now, such that the second use case is removed from the code and it only registers the menu item as a special item just like any other item. However, since the 'execute' path in special_items.yml needs to have some command, I also added an argument to the buildbattle command, namely /bb menu, which allows a player to open the BuildBattle menu. I then added this command argument to the config file and voila, once a player clicks the menu item (only while being in-game of course), the interacthandler properly fires and the Menu Item is fixed! :)

Next to this change, some other fixes have been applied:

• Enderpearls allowed players to teleport through the arena and visit other players plots. It even allowed during voting period to teleport away out of the map. I have disabled throwing enderpearls.
• RespawnAnchors could be loaded all up with glowstone and the explosion was not disabled. It could blow up the entire arena! I have disabled the explosion damage.
• Place rewards were firing multiple times for the same players. So a player ending first place would also receive second place, third place rewards, etc. This was due to incorrect usage of the MiniGamesBox api. It was a quick fix, but it works.
• Only the %player% placeholder works in the config.yml file, not uppercase %PLAYER%. I have changed the default generation of the config to the lowercase variant.
• Clicking on the first clock provided in the time change menu in the BuildBattle menu generated an error. I have resolved this error.

Hopefully these changes are welcome. I have worked quite a bit on them while trying to change as minimal as possible. Only the bare necessities should be fixed by this PR.

Thank you in advance! 😄

[Lagggpixel]

Thank you for your contributions.