Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for when prompt is undefined #1867

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

andyleejordan
Copy link
Member

Also improve regression test for when it throws.

Regression test for #1699.

Also improve regression test for when it throws.
@andyleejordan andyleejordan requested a review from a team August 3, 2022 20:55
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Test labels Aug 3, 2022
@andyleejordan andyleejordan enabled auto-merge (squash) August 3, 2022 20:55
…ts.cs

Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) August 3, 2022 21:05
@andyleejordan andyleejordan merged commit e49fa0a into main Aug 3, 2022
@andyleejordan andyleejordan deleted the andschwa/undefined-prompt-test branch August 3, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Test Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants