Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace in Pester symbol and add test #1893

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Fix whitespace in Pester symbol and add test #1893

merged 2 commits into from
Aug 15, 2022

Conversation

fflaten
Copy link
Contributor

@fflaten fflaten commented Aug 15, 2022

PR Summary

Trims leading whitespace in Pester symbol name. Also implements scaffolded regression test.

PR Context

Fix #1891

@fflaten fflaten requested a review from a team August 15, 2022 17:57
andyleejordan
andyleejordan approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you so much!

@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Pester labels Aug 15, 2022
@andyleejordan andyleejordan enabled auto-merge (squash) August 15, 2022 18:28
@fflaten
Copy link
Contributor Author

fflaten commented Aug 15, 2022

That CanUnregisterCommand test really hates PS5.1 😞

@andyleejordan
Copy link
Member

It really does 😭 these tests are a lot more stable than were...but yeah the 5.1 is still hella flaky.

@andyleejordan andyleejordan merged commit b0bfce7 into PowerShell:main Aug 15, 2022
@fflaten fflaten deleted the pester-symbolname branch August 15, 2022 19:45
@andyleejordan andyleejordan mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyleejordan andyleejordan andyleejordan approved these changes

Assignees
No one assigned
Labels
Area-Pester Issue-Enhancement A feature request (enhancement).
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pester symbols have leading whitespace in search
2 participants
@fflaten @andyleejordan