Fix stepping while watch expressions or interactive pipeline is running #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CancelDebugExecution` was supposed to exit early when the runspace was unusable. Basically forgot the `!` in the `if` statement.
When attempting to step, if we're in a nested debug frame that isn't a REPL we should stop execution before trying to exit the REPL.
Instead of a blank watch message we now write the exception message that was thrown from the attempt.
andyleejordan
approved these changes
Aug 15, 2022
| @@ -382,7 +382,7 @@ internal void MaybeAddToHistory() | |||
|
|
|||
| private void CancelDebugExecution() | |||
| { | |||
| if (_pwsh.Runspace.RunspaceStateInfo.IsUsable()) | |||
| if (!_pwsh.Runspace.RunspaceStateInfo.IsUsable()) | |||
There was a problem hiding this comment.
Was this just a big oops?
There was a problem hiding this comment.
Oh yeah, I meant to add a review comment pointing this out
BIG ol' oops there
|
@SeeminglyScience any chance you could open an issue just so we have this close a bug out? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Trying to step when any nested command that wasn't PSRL was running caused us to essentially ignore the request. This caused VSCode to think we were "running" while we didn't actually cancel anything.
PR Context