Add setting to control references code lens #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
andyleejordan
approved these changes
Aug 17, 2022
| @@ -22,6 +22,7 @@ internal class LanguageServerSettings | |||
| public CodeFoldingSettings CodeFolding { get; set; } | |||
| public PesterSettings Pester { get; set; } | |||
| public string Cwd { get; set; } | |||
| public bool EnableReferencesCodeLens { get; set; } | |||
There was a problem hiding this comment.
LMAO this defaulted to false which caused the unit test CanSendReferencesCodeLensRequestAsync to fail. Should we just default to true for now?
src/PowerShellEditorServices/Services/Workspace/LanguageServerSettings.cs
Outdated
Show resolved
Hide resolved
Which, being the existing default behavior, fixes the tests.
andyleejordan
added
Issue-Enhancement
andyleejordan
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This relies on PowerShell/vscode-powershell#4139
Adds a simple setting and update handler that adds/removes the references code lens.
PR Context
This gives folks the ability to disable the high perf impact code lens without disabling all other code lenses.