Fix file close in workspace service for Linux

[fflaten]

PR Summary

Use a consistent dictionary key for CRUD operations in WorkspaceService.workspaceFiles

PR Context

Fix #1901

[andyleejordan]

Hahaha, I remember seeing this bug and just forgetting to fix it. Thank you so much 😄

[fflaten]

Should ScriptFile.Id maybe just be a guid?

PowerShellEditorServices/src/PowerShellEditorServices/Services/TextDocument/ScriptFile.cs

Lines 35 to 40 in 0b96dae

	/// <summary>
	/// Gets a unique string that identifies this file. At this time,
	/// this property returns a normalized version of the value stored
	/// in the FilePath property.
	/// </summary>
	public string Id => FilePath.ToLower();

Looks like it's only used internally atm which could use the same helper, but I guess we'd want a public Id for future use. Could possibly cause conflicts on Linux atm.

PowerShellEditorServices/src/PowerShellEditorServices/Services/Workspace/WorkspaceService.cs

Lines 306 to 326 in 0b96dae

	public ScriptFile[] ExpandScriptReferences(ScriptFile scriptFile)
	{
	Dictionary<string, ScriptFile> referencedScriptFiles = new();
	List<ScriptFile> expandedReferences = new();
	// add original file so it's not searched for, then find all file references
	referencedScriptFiles.Add(scriptFile.Id, scriptFile);
	RecursivelyFindReferences(scriptFile, referencedScriptFiles);
	// remove original file from referenced file and add it as the first element of the
	// expanded referenced list to maintain order so the original file is always first in the list
	referencedScriptFiles.Remove(scriptFile.Id);
	expandedReferences.Add(scriptFile);
	if (referencedScriptFiles.Count > 0)
	{
	expandedReferences.AddRange(referencedScriptFiles.Values);
	}
	return expandedReferences.ToArray();
	}

[fflaten]

Hahaha, I remember seeing this bug and just forgetting to fix it. Thank you so much 😄

Initially hoped it would improve symbol search perf by not keeping to many files opened in the service, but it won't. Apparently there are many ways files get opened but only closing them in editor will trigger CloseFile() to remove them from service. So now it's just a bugfix 😄

[andyleejordan]

I'm getting tempted to skip DebuggerSetsVariablesNoConversion as it's also being really flaky.