Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove null markers to avoid NullReferenceException #1907

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Remove null markers to avoid NullReferenceException #1907

merged 1 commit into from
Aug 25, 2022

Conversation

andyleejordan
Copy link
Member

Resolves #1906.

@andyleejordan andyleejordan requested a review from a team August 25, 2022 20:22
@ghost ghost added Area-Script Analysis Issue-Bug A bug to squash. labels Aug 25, 2022
@andyleejordan
Copy link
Member Author

@dkattan and @fflaten could you review this for me?

@andyleejordan andyleejordan enabled auto-merge (squash) August 25, 2022 20:23
dkattan
dkattan approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@dkattan dkattan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SydneyhSmith SydneyhSmith self-requested a review August 25, 2022 20:29
@andyleejordan andyleejordan merged commit 64a2681 into main Aug 25, 2022
@andyleejordan andyleejordan deleted the andschwa/removeNullMarkers branch August 25, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkattan dkattan dkattan approved these changes

@SydneyhSmith SydneyhSmith SydneyhSmith approved these changes

Assignees
No one assigned
Labels
Area-Script Analysis Issue-Bug A bug to squash.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException in GetDiagnosticFromMarker
3 participants
@andyleejordan @dkattan @SydneyhSmith