Catch exceptions within completion handler #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
andyleejordan
force-pushed
the
andschwa/handle-failed-completions
branch
5 times, most recently
from
ade9d58
to
3f22ad4
Compare
SeeminglyScience
approved these changes
Oct 24, 2022
src/PowerShellEditorServices/Services/TextDocument/Handlers/CompletionHandler.cs
Outdated
Show resolved
Hide resolved
andyleejordan
force-pushed
the
andschwa/handle-failed-completions
branch
2 times, most recently
from
620e2f4
to
0948131
Compare
We'll still see the same error in the log, but as a warning and not as an exception bubbled up over LSP that causes some clients, like Kate, to crash. We can't do anything about PowerShell's completion failing.
andyleejordan
force-pushed
the
andschwa/handle-failed-completions
branch
from
0948131
to
fb62522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll still see the same error in the log, but as a warning and not as an exception bubbled up over LSP that causes some clients, like Kate, to crash. We can't do anything about PowerShell's completion failing.
Fixes #1926.