Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToggleISEMode command with tests #4117

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Add ToggleISEMode command with tests #4117

merged 1 commit into from
Aug 17, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Aug 9, 2022 •
edited
Loading

So it can be turned on and off more easily, especially if wired to a button like in a walkthrough.

@andyleejordan andyleejordan requested a review from a team August 9, 2022 03:43
@andyleejordan andyleejordan marked this pull request as draft August 11, 2022 22:56
@andyleejordan
Add ToggleISEMode command with tests
8230a48 
So it can be turned on and off more easily, especially if wired to a
button like in a walkthrough.
@andyleejordan andyleejordan changed the title WIP: Add ToggleISEMode command Add ToggleISEMode command with tests Aug 17, 2022
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-ISE Compatibility labels Aug 17, 2022
@andyleejordan andyleejordan marked this pull request as ready for review August 17, 2022 17:15
@andyleejordan andyleejordan enabled auto-merge (squash) August 17, 2022 17:15
SeeminglyScience
SeeminglyScience approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit a310fd8 into main Aug 17, 2022
@andyleejordan andyleejordan deleted the andschwa/ise-toggle branch August 17, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees
No one assigned
Labels
Area-ISE Compatibility Issue-Enhancement A feature request (enhancement).
Projects
No open projects
American Pharoah
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyleejordan @SeeminglyScience