Use vscode.workspace.fs and suppress startup banner for dotnet installs of PowerShell
#4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have file/directory existence logic in too many places.
So we can use `for await` etc.
|
I bit off a bit more than I intended to with this one @SeeminglyScience. |
andyleejordan
changed the title
vscode.workspace.fs and clean-upvscode.workspace.fs and suppress startup banner for dotnet installs of PowerShell
ghost
added
andyleejordan
force-pushed
the
andschwa/exists-cleanup
branch
2 times, most recently
from
508c033
to
2f3a59f
Compare
andyleejordan
force-pushed
the
andschwa/exists-cleanup
branch
from
2f3a59f
to
86b7fe5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was some yak-shaving. I added
supportsProperArgumentstoPossiblePowerShellExeso we can special-case thedotnetinstaller and drop the startup banner (since it doesn't support proper argument parsing).Fixes #4111.