Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vscode-languageclient and refactor (a lot of TLC) #4131

Merged
merged 5 commits into from
Aug 12, 2022
Merged

Update vscode-languageclient and refactor (a lot of TLC) #4131

merged 5 commits into from
Aug 12, 2022

Commits on Aug 12, 2022

  1. Update vscode-languageclient etc. and npm dedupe 

    Also update our engine to align with ADS's update to 1.62.0.
Unfortunately, we still have unresolved work pending their update to
1.65.0.
    @andyleejordan
    andyleejordan committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    7a36bd0 View commit details
    Browse the repository at this point in the history

  2. Update use of LanguageClient 

    Lots of clean-up, a little refactoring, and most importantly, a less
buggy `LanguageClient` implementation (which is less prone to race
conditions). Also handle disposal of handler registrations.
    @andyleejordan
    andyleejordan committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    093f7e0 View commit details
    Browse the repository at this point in the history

  3. Replace forEach(...) for for (_ of ...) 

    It's faster...it reads better.
    @andyleejordan
    andyleejordan committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    3f98b1a View commit details
    Browse the repository at this point in the history

  4. Remove nearly all remaining uses of Node.JS fs module 

    The last one involves a stream.
    @andyleejordan
    andyleejordan committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    697722c View commit details
    Browse the repository at this point in the history

  5. Bump VS Code engine to 1.65.0 

    This is necessary to take the language client library update.
Unfortunately it means that ADS won't be able to take the next update to
our extension until they catch up to at least this engine version. It
could be worse, we didn't have to bump to 1.7x.
    @andyleejordan
    andyleejordan committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    e93425d View commit details
    Browse the repository at this point in the history