Improve language client library close action message #4141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The updated language client library now displays an error when the connection to the server terminates. Thing is, we already have our own restart experience where we inform the user that the terminal should be restarted, and give them a Yes/No option to do so. Unfortunately, we can't suppress this error message, and I don't think that we want to auto-restart the terminal, so I've at least made the message a little more clear.
andyleejordan
force-pushed
the
andschwa/close-action-message
branch
from
451a34a
to
b1ac63c
Compare
|
@SeeminglyScience @SydneyhSmith I've asked the upstream library to either add a
|
SydneyhSmith
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated language client library now displays an error when the connection to the server terminates. Thing is, we already have our own restart experience where we inform the user that the terminal should be restarted, and give them a Yes/No option to do so. Unfortunately, we can't suppress this error message, and I don't think that we want to auto-restart the terminal, so I've at least made the message a little more clear.