Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect docstring for powershell.cwd #4171

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

andyleejordan
Copy link
Member

This variable never could have accepted VS Code predefined variables because support for that is still an open feature request upstream. We have no API to resolve predefined variables in values given to contributed settings, and so cannot support this.

Resolves #4163

This variable never could have accepted VS Code predefined variables
because support for that is still an open feature request upstream. We
have no API to resolve predefined variables in values given to
contributed settings, and so cannot support this.
@andyleejordan andyleejordan requested a review from a team September 13, 2022 00:27
@ghost ghost added Area-Workspaces Issue-Bug A bug to squash. labels Sep 13, 2022
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor wording suggestion

package.json Outdated Show resolved Hide resolved
Co-authored-by: Patrick Meinecke <SeeminglyScience@users.noreply.github.com>
@andyleejordan andyleejordan enabled auto-merge (squash) September 13, 2022 19:34
@andyleejordan andyleejordan merged commit df9f374 into main Sep 13, 2022
@andyleejordan andyleejordan deleted the andschwa/update-setting-docstring branch September 13, 2022 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace folder pick pops up if a predefined variable is used for the powershell.cwd setting
2 participants