Refactor the debug launch configuration resolvers #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some much needed TLC, especially now that VS Code with resolve its predefined variables used in configurations. Do not set `cwd` for debug launch configurations Instead, respect it if it exists, and otherwise consistently do not change it. Debugging will run in the session's current `cwd`, or if and only if the user set `cwd` on the launch config will it change.
ghost
added
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some much needed TLC, especially now that VS Code with resolve its predefined variables used in configurations.
Do not set
cwdfor debug launch configurationsInstead, respect it if it exists, and otherwise consistently do not change it. Debugging will run in the session's current
cwd, or if and only if the user setcwdon the launch config will it change.Resolves #4082. My own testing seems to indicate this works well and as expected (consistently). However, I suspect we'll get some complaints when it rolls out.