Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement indicator when running registered editor commands #4187

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Sep 28, 2022

Resolves #3954 and uses the new language status bar item. Essentially just adds a spinner when the editor command is running.

@andyleejordan andyleejordan marked this pull request as ready for review September 28, 2022 20:37
@andyleejordan andyleejordan requested a review from a team September 28, 2022 20:37
@ghost ghost added Area-UI Issue-Enhancement A feature request (enhancement). labels Sep 28, 2022
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit b3fb068 into main Sep 28, 2022
@andyleejordan andyleejordan deleted the andschwa/editor-command-status branch September 28, 2022 20:52
@shangles
Copy link

I want to thank everyone involved in restoring this functionality to the PowerShell plug-in in Visual Studio Code. I hope you all have a wonderful weekend. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add back "PowerShell" text indicator when running a "Editor Command"
3 participants