Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle busy notification for all PowerShell tasks #4193

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Sep 30, 2022

Since with PowerShell/PowerShellEditorServices#1928 the server now sends a busy notification for any PowerShell task, not just registered editor commands, we can handle this in the session class.

@andyleejordan andyleejordan changed the title WIP: Generalized busy indicator Handle busy notification for all PowerShell tasks Sep 30, 2022
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-UI labels Sep 30, 2022
@andyleejordan andyleejordan marked this pull request as ready for review September 30, 2022 19:17
@andyleejordan andyleejordan requested a review from a team September 30, 2022 19:17
@andyleejordan andyleejordan enabled auto-merge (squash) September 30, 2022 20:15
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit f5b45b3 into main Sep 30, 2022
@andyleejordan andyleejordan deleted the andschwa/busy-indicator branch September 30, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Enhancement A feature request (enhancement).
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants