Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture more logs #4240

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Capture more logs #4240

merged 1 commit into from
Nov 2, 2022

Conversation

andyleejordan
Copy link
Member

@andyleejordan andyleejordan commented Nov 2, 2022

This improves the logger to start much earlier, auto-create the directory, and log the directory paths for #4202.

@andyleejordan andyleejordan requested a review from a team November 2, 2022 18:41
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Logging labels Nov 2, 2022
@andyleejordan andyleejordan force-pushed the andschwa/more-logs branch 2 times, most recently from 8948895 to 053846d Compare November 2, 2022 18:51
By starting the logger earlier.
Copy link
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan enabled auto-merge (squash) November 2, 2022 18:59
@andyleejordan andyleejordan merged commit 7a40cb3 into main Nov 2, 2022
@andyleejordan andyleejordan deleted the andschwa/more-logs branch November 2, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Logging Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants