Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Ensure credits.aleo keys are fetched from SnarkVM instead of a remote #907

Merged
merged 9 commits into from
Aug 3, 2024

Conversation

iamalwaysuncomfortable
Copy link
Collaborator

Motivation

Some SDK users have been having issues with the Key Provider. This is because formerly during Testnet3, verifying keys were fetched from a remote. They are now provided via SnarkVM, this PR updates the KeyProvider to use the keys directly from SnarkVM.

…ame, and remove caller parameter from all transfer function calls
Copy link
Collaborator

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@jaketarnow jaketarnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated fixes allow for program deployment, execution, account creation, and transfers!

LGTM

@iamalwaysuncomfortable iamalwaysuncomfortable merged commit 5dc5587 into testnet3 Aug 3, 2024
10 checks passed
@iamalwaysuncomfortable iamalwaysuncomfortable deleted the feat/key-provider-fix-example branch August 3, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants