Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the result of __index__ when converting to Rust BigInts. #1027

Merged
merged 3 commits into from
Jul 9, 2020
Merged

Use the result of __index__ when converting to Rust BigInts. #1027

merged 3 commits into from
Jul 9, 2020

Conversation

noam93k
Copy link
Contributor

@noam93k noam93k commented Jul 7, 2020

Thank you for contributing to pyo3!

Here are some things you should check for submitting your pull request:

  • Run cargo fmt (This is checked by travis ci)
  • Run cargo clippy and check there are no hard errors (There are a bunch of existing warnings; This is also checked by travis)
  • If applicable, add an entry in the changelog.
  • If applicable, add documentation to all new items and extend the guide.
  • If applicable, add tests for all new or fixed functions
  • If you changed any python code, run black .. You can install black with pip install black)

You might want to run tox (pip install tox) locally to check compatibility with all supported python versions. If you're using linux or mac you might find the Makefile helpful for testing.

@davidhewitt
Copy link
Member

Thanks, LGTM. I've added a CHANGELOG entry and will merge once CI succeeds.

@davidhewitt davidhewitt merged commit bd97b25 into PyO3:master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants