Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove test_pep_587 #3769

Merged
merged 1 commit into from
Jan 27, 2024
Merged

remove test_pep_587 #3769

merged 1 commit into from
Jan 27, 2024

Conversation

davidhewitt
Copy link
Member

Related to #3762

This test uses _Py_InitializeMain as part of its machinery for testing PEP 587 embedding. Also, it was originally built as a crude way to check that the FFI structure definitions were correct.

It was originally introduced in #2374 and pyo3-ffi-check didn't come until later in #2423.

So, I think that for now it's best if we just remove this test, to get rid of the CPython-private _Py_InitializeMain usage.

I suspect that once we drop Python 3.7 we'll be implementing some new replacement for prepare_freethreaded_python which uses the PEP 587 APIs, so at that point we'll be adding more coverage again too.

@davidhewitt davidhewitt added the CI-skip-changelog Skip checking changelog entry label Jan 27, 2024
Copy link
Contributor

@alex alex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiven that this really tests only the ffi layer, I agree that's better covered by the ffi-check

@davidhewitt davidhewitt added this pull request to the merge queue Jan 27, 2024
Merged via the queue into PyO3:main with commit eb8d11f Jan 27, 2024
39 checks passed
@davidhewitt davidhewitt deleted the remove-test-pep-587 branch January 27, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-changelog Skip checking changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants