Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error messages for unsupported macro features on compilation #4194

Merged
merged 29 commits into from
Jun 16, 2024
Merged

Add error messages for unsupported macro features on compilation #4194

merged 29 commits into from
Jun 16, 2024

Commits on May 26, 2024

  1. First implementation

    @cojmeister @codeguru42
    cojmeister authored and codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    ffa283f View commit details
    Browse the repository at this point in the history

  2. tweak error message wording

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    61c488f View commit details
    Browse the repository at this point in the history

  3. Fix boolean logic

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    2dda39c View commit details
    Browse the repository at this point in the history

  4. Remove redundant parens

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    f1f3efb View commit details
    Browse the repository at this point in the history

  5. Add test for weakref error

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    e4719c3 View commit details
    Browse the repository at this point in the history

  6. Fix test

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    0e25b7c View commit details
    Browse the repository at this point in the history

  7. Reword error message

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    36b28d2 View commit details
    Browse the repository at this point in the history

  8. Add expected error output

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    bfa8cb6 View commit details
    Browse the repository at this point in the history

  9. Rinse and repeat for dict

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    219202f View commit details
    Browse the repository at this point in the history

  10. Add test output file

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    03c2cdc View commit details
    Browse the repository at this point in the history

  11. Ignore Rust Rover config files

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    2df737c View commit details
    Browse the repository at this point in the history

  12. cargo fmt

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    08891c9 View commit details
    Browse the repository at this point in the history

  13. Add newsfragment

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    af3d93d View commit details
    Browse the repository at this point in the history

  14. Update newsfragments/4194.added.md 

    Co-authored-by: David Hewitt <mail@davidhewitt.dev>
    @codeguru42 @davidhewitt
    codeguru42 and davidhewitt committed May 26, 2024
    Configuration menu
    Copy the full SHA
    e22a51a View commit details
    Browse the repository at this point in the history

  15. Use ensure_spanned! macro 

    Co-authored-by: David Hewitt <mail@davidhewitt.dev>
    @codeguru42 @davidhewitt
    codeguru42 and davidhewitt committed May 26, 2024
    Configuration menu
    Copy the full SHA
    aaf6fa7 View commit details
    Browse the repository at this point in the history

  16. Use ensure_spanned! macro for weakref error, too 

    Co-authored-by: David Hewitt <mail@davidhewitt.dev>
    @codeguru42 @davidhewitt
    codeguru42 and davidhewitt committed May 26, 2024
    Configuration menu
    Copy the full SHA
    0336aeb View commit details
    Browse the repository at this point in the history

  17. Revert "Ignore Rust Rover config files" 

    This reverts commit 6c8a2ee.
    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    c5dcad8 View commit details
    Browse the repository at this point in the history

  18. Update wording for error message 

    Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
    @codeguru42 @Icxolu
    codeguru42 and Icxolu committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6e83437 View commit details
    Browse the repository at this point in the history

  19. Update weakref error message, too

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    490cee4 View commit details
    Browse the repository at this point in the history

  20. Refactor constant to a pyversions module

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    9fb5196 View commit details
    Browse the repository at this point in the history

  21. Fix compiler errors

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    5253cf4 View commit details
    Browse the repository at this point in the history

  22. Another wording update 

    Co-authored-by: David Hewitt <mail@davidhewitt.dev>
    @codeguru42 @davidhewitt
    codeguru42 and davidhewitt committed May 26, 2024
    Configuration menu
    Copy the full SHA
    a2a9452 View commit details
    Browse the repository at this point in the history

  23. And make weakref wording the same

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    77a9101 View commit details
    Browse the repository at this point in the history

  24. Fix compiler error due to using weakref in our own code

    @codeguru42
    codeguru42 committed May 26, 2024
    Configuration menu
    Copy the full SHA
    28cbbc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge remote-tracking branch 'refs/remotes/upstream/main' into add-er… 

    …ror-messages-for-unsupported-macro-features-on-compilation

# Conflicts:
#	pyo3-macros-backend/src/pyclass.rs
    @codeguru42
    codeguru42 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    abd1075 View commit details
    Browse the repository at this point in the history

  2. Fix after merge

    @codeguru42
    codeguru42 committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    680f471 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. apply conditional pyclass

    @davidhewitt
    davidhewitt committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    4fbbe98 View commit details
    Browse the repository at this point in the history

  2. update conditional compilation in tests

    @davidhewitt
    davidhewitt committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7177d53 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Merge remote-tracking branch 'refs/remotes/upstream/main' into add-er… 

    …ror-messages-for-unsupported-macro-features-on-compilation

# Conflicts:
#	tests/test_class_basics.rs
    @codeguru42
    codeguru42 committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    3c7e898 View commit details
    Browse the repository at this point in the history