Don't raise TypeError from generated equality method
#4287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense and looks right to me. |
davidhewitt
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating a project to replace manually-written
__eq__()methods with the new#[pyclass(eq)]option added in 0.22, I found that doing so causes aTypeErrorto be raised when objects of different types are checked for equality. I believe it should returnNotImplementedinstead, to stay consistent with pyclasses that use__eq__()and standard Python types.This PR contains the change, and a test to confirm the comparison behavior.
Please let me know how this looks, particularly the tests -- I'm not sure if I got those in the right spot 🙂 Thanks!