Fix handling of invalid utf-8 sequences in PyString::to_string_lossy #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kngwyu
approved these changes
Oct 24, 2019
src/types/string.rs
Outdated
| // Since we have a valid PyString and replace any surrogates, assume success. | ||
| debug_assert!(!py_bytes.is_null()); | ||
| // ensure DECREF will be called | ||
| self.py().from_owned_ptr::<PyBytes>(py_bytes); |
There was a problem hiding this comment.
How about crate::gil::register_pointer?(My snippet was incorrect, sorry)
There was a problem hiding this comment.
Ok, done. What's the difference?
There was a problem hiding this comment.
- Less overhead.
- Our GIL pool has 3 types of buffer(owned ref, borrowed ref, pointer).
In this case, we can use both owned and pointer buffer.
But pointer buffer is preferable for the caseGILGuarddrops earlier(I'll add an example but have no time now 😓 ).
|
Thanks! |
Alexander-N
force-pushed
the
to_string_lossy
branch
from
0554812
to
defa430
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion in #479 and #634.