Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to pass filetype and rt unit #68

Merged
merged 17 commits into from
Sep 3, 2021
Merged

Added support to pass filetype and rt unit #68

merged 17 commits into from
Sep 3, 2021

Conversation

hechth
Copy link
Member

@hechth hechth commented Aug 30, 2021

Made passing rt_unit non-optional to avoid bugs and make the user aware of this requirement.
Added passing rt_unit via CLI.
Added filetype flag and removed dependency on filename extension.

Fixes #64
Fixes #67

@hechth
Update README.md
23f6648
@hechth
Merge branch 'RECETOX:main' into main
0f71b21
@hechth
Merge branch 'RECETOX:main' into main
2652ee9
@hechth
Changed signature of Data to make rt time unit non-optional and added…
6b39a6c 
… filetype field
@hechth
Changed MatchMSData to accept filetype flag
f342c6d
@hechth
Implemented tests to check filetype
7508dbe
@hechth
Changed import of builders using __init__.py file
9f92b06
@hechth
Added csv as default filetype to data builder
3f76602
@hechth
Removed unused imports
2711334
@hechth
Fixed linter
65b925b
@hechth
Generalized filetype tests to be useable on both data implementations
b4fb533
@hechth
Changed extension function to return actual extension only, without .
1e22f7e
@hechth
Adapted to new version of extension function
6f37bfd
@hechth
Changed LoadDataAction to take 3 parameters, filename, filetype and r…
139a24c 
…t_unit
@hechth
Added information to changelog
567fb67
@hechth
Changed __main__ to take all 3 cli parameters
cf690be
@hechth hechth added bug Something isn't working enhancement New feature or request labels Aug 30, 2021
@hechth hechth added this to the GC workflow prototype milestone Aug 30, 2021
@martenson martenson merged commit 02ffe72 into RECETOX:main Sep 3, 2021
@martenson
Copy link
Member

Thanks for implementing this @hechth !

@martenson martenson mentioned this pull request Sep 3, 2021
Closed
@hechth hechth deleted the 65_release_0_3 branch January 25, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximskorik maximskorik maximskorik approved these changes

@martenson martenson Awaiting requested review from martenson

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
GC workflow prototype
Development

Successfully merging this pull request may close these issues.

do not rely on filenames for datatype Add passing of time unit information in command line interface
3 participants
@hechth @martenson @maximskorik