Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace non-test asserts with exceptions; lint #91

Merged
merged 5 commits into from
May 26, 2022
Merged

replace non-test asserts with exceptions; lint #91

merged 5 commits into from
May 26, 2022

Conversation

martenson
Copy link
Member

@martenson martenson commented May 26, 2022 •
edited
Loading

closes #88

@martenson martenson changed the title resolve whitespace part of #88 replace non-test asserts with exceptions; lint May 26, 2022
hechth
hechth approved these changes May 26, 2022
View reviewed changes
Copy link
Member

@hechth hechth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @martenson for taking care of this!

@hechth hechth merged commit 5ca1452 into main May 26, 2022
@martenson martenson deleted the whitespace-lint branch May 31, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hechth hechth hechth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JOSS Review] Functionality documentation: linting/style
2 participants
@martenson @hechth