Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[implicit GEMM] CalculateGemmSize() should not be a public member function of a Solver #867

Closed
atamazov opened this issue Apr 19, 2021 · 2 comments
Closed

[implicit GEMM] CalculateGemmSize() should not be a public member function of a Solver #867

atamazov opened this issue Apr 19, 2021 · 2 comments
Assignees
@junliume @asroy
Labels
quality urgency_normal

Comments

@atamazov
Copy link
Contributor

  • Solver does not have any member data, so static or unnamed namespace should work in the most cases.
  • If you need inheritance, make it private at least.

Solver design must comply the #866.
@atamazov atamazov mentioned this issue Apr 19, 2021
Merged
@averinevg
Copy link
Collaborator

@atamazov @junliume Fixed in #1438

@atamazov
Copy link
Contributor Author

atamazov commented Nov 1, 2022

@averinevg 👍

@atamazov atamazov closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junliume junliume

@asroy asroy

Labels
quality urgency_normal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@junliume @atamazov @asroy @averinevg