Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[solvers] Access modifiers for solvers #1438

Merged
merged 57 commits into from
Jun 7, 2022
Merged

[solvers] Access modifiers for solvers #1438

merged 57 commits into from
Jun 7, 2022

Conversation

averinevg
Copy link
Collaborator

@averinevg averinevg commented Feb 22, 2022 •
edited
Loading

  • Added access modifiers
  • Marked solvers as final

@averinevg averinevg marked this pull request as ready for review February 22, 2022 13:32
@averinevg averinevg marked this pull request as draft February 22, 2022 13:43
@codecov

This comment was marked as off-topic.

Sign in to view
@DrizztDoUrden
Copy link
Contributor

To be honest, I don't like the idea of interface public methods being named with _ on the end.

@averinevg averinevg changed the base branch from searchable_solver_base to develop May 30, 2022 18:27
@averinevg averinevg marked this pull request as ready for review May 31, 2022 17:19
@averinevg
Copy link
Collaborator Author

@atamazov @DrizztDoUrden @JehandadKhan @junliume Please review

atamazov
atamazov approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@atamazov atamazov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@junliume junliume merged commit 62d20d4 into develop Jun 7, 2022
@averinevg averinevg deleted the solvers_add_access_modifiers branch September 9, 2022 08:11
@averinevg averinevg mentioned this pull request Oct 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JehandadKhan JehandadKhan JehandadKhan approved these changes

@junliume junliume junliume approved these changes

@atamazov atamazov atamazov approved these changes

@DrizztDoUrden DrizztDoUrden Awaiting requested review from DrizztDoUrden

Assignees
No one assigned
Labels
enhancement quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@averinevg @DrizztDoUrden @JehandadKhan @junliume @atamazov