[SWDEV-300279][MSRCHA-140] Batchnorm backward convergence fix #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
junliume
reviewed
Aug 26, 2021
| @@ -865,7 +865,7 @@ void BatchNormBackward(Handle& handle, | |||
| // N*H*W < 32M and H*W > 1024, use batchnorm variant#1 implementation which parallelize | |||
| // work groups over channels and loop through NHW. | |||
| //************************************************************************************************* | |||
| if((in_nhw < (32 * 1024 * 1024) && in_cstride > 1024) || (n > 768)) | |||
There was a problem hiding this comment.
Why batch sizes greater 768 will have problem parallelize work groups over channels and loop through NHW? Just curious how this has fixed the converge issue. Thanks1
There was a problem hiding this comment.
We should always check HW (in_cstride) which is missing in this case. We were using batchnorm variant#1 for batch sizes > 768 which is having issues for these batch sizes when HW is small. I have corrected it to use correct variant. This bug might have been introduced inadvertently. I fixed it.
junliume
changed the title
|
Ping @ce1adon for review. One line change only. Thanks! |
ce1adon
approved these changes
Aug 26, 2021
junliume
changed the title
atamazov
reviewed
Aug 27, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will address batchnorm backward convergence issue for batch sizes greater 768.