Fix the dynamic reduction GPU Memory Acccess failure with double on ROCM 4.3 #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/reducetensor.cpp
This comment has been minimized.
This comment has been minimized.
asroy
previously requested changes
Aug 31, 2021
|
There is some problem with the CI |
Maybe you could restart the test. |
|
Luckily, the CI just passed |
|
After ~15 retries... awesome :/ |
atamazov
approved these changes
Sep 6, 2021
|
@qianfengz No answer required, I see the explanation at #1123 (comment) |
junliume
approved these changes
Sep 7, 2021
junliume
dismissed
asroy’s stale review
Review outdated and PR changed accordingly
junliume
pushed a commit
that referenced
this pull request
Sep 30, 2021
…e on ROCM 4.3 (#1131) * Fix the calculation of ws_buf2_bytes_offset for dynamic reduction in src/reducetensor.cpp * Just remove IsDynamicReductionEnabled() * Tiny fix in ReduceTensorDescriptor::GetWorkspaceSize() * Update to the calculation of ws_buf2_bytes_offset
This was referenced Sep 30, 2021
junliume
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1123 (pls. see explanation here).
The issue has been reproduced with ROCM 4.3 on both MI100 and MI25.
This fix has passed the testing with ROCM 4.2/ROCM 4.3/ROCM 4.3.1 on either MI100 or MI25.