[MLIR] Implement tuning - step 3: bwd, nonxdlops + xdlops #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryyin
force-pushed
the
mlir-tuning-bwd
branch
from
82964d5
to
a000cfc
Compare
This comment has been minimized.
This comment has been minimized.
junliume
approved these changes
Sep 12, 2021
atamazov
reviewed
Sep 13, 2021
| construction_parameters.kernel_file = construction_parameters.kernel_name + ".mlir"; | ||
|
|
||
| if(config == PerformanceConvMlirIgemmXdlops()) | ||
| // At this case, do not pass in the invalid perf config and instead make Miir library to do | ||
| // heuristic initialization | ||
| construction_parameters.comp_options = | ||
| mlir::ConstructBuildOptions(ctx, GetOperation(), GetKernelName(), true); | ||
| construction_parameters.comp_options = mlir::ConstructBuildOptions(ctx, true); |
atamazov
reviewed
Sep 13, 2021
Comment on lines
+57
to
+61
| PerformanceConvMlirIgemm ConvMlirIgemmBwd::GetPerformanceConfig(const ConvolutionContext& ctx) const | ||
| { | ||
| std::ignore = ctx; | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
This produces invalid performance config, which does not match the specification. Why this is done in GetSoluiton but not in this function?
There was a problem hiding this comment.
Ping @jerryyin to check. Sorry to have missed it in last review.
There was a problem hiding this comment.
I agree it break the existing specification, but this is intentional. I will explain why I made this decision in #1154 in case this thread becomes too long. Then based on the discussion result, we can decide what's the best behavior it is for mlir solvers.
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
PerformanceConvMlirIgemmfor bwd solverPerformanceConvMlirIgemmXdlopsfor bwd xdlops solvermlir_common.cppGetKernelName()andGetOperation()into it to make it solver independentTest on
ConvMlirIgemmBwdCommand:
Log:
Test on
ConvMlirIgemmBwdXdlopsCommand:
Log:
Previous PR this series: