[tests] Disable test_regression_opencl_float_mi100 if WORKAROUND_ISSUE_1317 is set. #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junliume I highly recommend merging it to Staging and Mainline before 5.0 is cut. |
atamazov
commented
Dec 18, 2021
| @@ -173,6 +173,9 @@ option( WORKAROUND_ISSUE_1334 "" ${WORKAROUND_ISSUE_1334_DEFAULT}) | |||
| set_var_to_condition(WORKAROUND_SWDEV_292187_DEFAULT MIOPEN_TEST_GFX1030) | |||
| option( WORKAROUND_SWDEV_292187 "" ${WORKAROUND_SWDEV_292187_DEFAULT}) | |||
|
|
|||
| set_var_to_condition(WORKAROUND_ISSUE_1317_DEFAULT MIOPEN_TEST_OPENCL) | |||
There was a problem hiding this comment.
Actually this is too much and WORKAROUND_ISSUE_1317 can be simply set to On, but there is no harm.
This comment has been minimized.
This comment has been minimized.
|
Guys, please review. |
junliume
approved these changes
Dec 19, 2021
atamazov
added a commit
that referenced
this pull request
Dec 29, 2021
…d (Staging 95b58f7) (#1317) and Implement abstraction for multi-buffer workspace (#1326) (#1327) * add a class to represent workspace buffer traits * add workspace buffer alignment for bwd and wrw * comment out W/A 1317 * remove WORKAROUND_ISSUE_1317 macro * fix ctest bug for transpose+asm igemm case: weights c=c/groups * Update src/conv/invokers/impl_gemm_dynamic.cpp * Revert "[tests] Disable test_regression_opencl_float_mi100 if WORKAROUND_ISSUE_1317 is set. (#1352)" Co-authored-by: Artem Tamazov <artem.tamazov@gmail.com> Co-authored-by: Jun Liu <Liu.Jun@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1351 and unblocks CI (the failures are random).