Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sl/google test #1726

Merged
merged 17 commits into from
Sep 1, 2022
Merged

Sl/google test #1726

merged 17 commits into from
Sep 1, 2022

Conversation

xinlipn
Copy link
Contributor

@xinlipn xinlipn commented Aug 30, 2022

New changes were made on PR1611 after it's tagged as TESTING_CI_PASSED, which seems to causing merge/conflict. This seems to be an issue with the merge process.

Therefore, a new PR is created to include the changes and resolve conflicts if any.

root added 15 commits June 22, 2022 09:34
Adding GoogleTest to Test framework
ec5fe42
Added cache.cpp test to GoogleTest, to reduce duplicated code
81b73f7
Add cache test to GoogleTest
9254c80
LWPTUNA-53-1: Moved Cache.cpp and updated with googletest TEST()
8f1216e
Clean up gtest/CMakeLists.txt
7e5303d
PR#1611: Refactored activation test with GoogleTest
1f0d964
Added new include directories to eliminate the dependancy of specifiy…
4f8ab4b 
…ing up-level directory when including header files
Resolve Target not found CMake error on roc::rocblas
0639314
Test if activation.cpp warning is causing CPPcheck failure in Hip Tidy
12a2a3e
Fix Cppcheck warnings
1a8dda4
Bumped CMake ver from 3.5 to 3.11+ to support FetechContent
8419573
Force docker to rebuild with changes to Jenkinsfile; will revert shor…
a59b507 
…tly; clean up accidentally checked in gtest code from other branche
Revert the workaround in Jenkinsfile to force rebuild docker
5d1413a
PR:1611 clean up Docerfile and Jenkinsfile
7a65517
revert the changes that is meant for PR1628
030457b
@xinlipn xinlipn self-assigned this Aug 30, 2022
@junliume
Copy link
Collaborator

junliume commented Sep 1, 2022

Redo of #1611 refer to that PR for review comments history

@junliume junliume merged commit dd14f09 into develop Sep 1, 2022
@atamazov
Copy link
Contributor

atamazov commented Sep 1, 2022

@xinlipn @junliume

New changes were made on PR1611 after it's tagged as TESTING_CI_PASSED, which seems to causing merge/conflict. This seems to be an issue with the merge process.

Therefore, a new PR is created to include the changes and resolve conflicts if any.

There is no merge conflicts in #1611. I do not see any differences vs this PR either (except one filename -- hello_gtest.cpp vs hello_test.cpp). Therefor I think that the root reason of the issue with #1611 is not known yet.

@junliume
Copy link
Collaborator

junliume commented Sep 1, 2022

@xinlipn @junliume

New changes were made on PR1611 after it's tagged as TESTING_CI_PASSED, which seems to causing merge/conflict. This seems to be an issue with the merge process.
Therefore, a new PR is created to include the changes and resolve conflicts if any.

There is no merge conflicts in #1611. I do not see any differences vs this PR either (except one filename -- hello_gtest.cpp vs hello_test.cpp). Therefor I think that the root reason of the issue with #1611 is not known yet.

CC: @JehandadKhan
I think it's related to a change in docker register recently via #1696 one has to merge most recent develop branch to ensure the CI will pass.

@atamazov atamazov mentioned this pull request Nov 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junliume junliume junliume approved these changes

Assignees

@xinlipn xinlipn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinlipn @junliume @atamazov