igemm WrW invokers #233

DrizztDoUrden · 2020-05-21T14:28:41Z

Blocker for #203 as some of the solvers here are tunable.

ghost · 2020-05-21T14:28:56Z

Congratulations 🎉. DeepCode analyzed your code in 2.588 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

…kers

daniellowell · 2020-06-10T19:59:19Z

Reviews?

DrizztDoUrden · 2020-06-11T14:41:25Z

I just pray not to have any more solver merges here. They are trivial but require a hell lot of testing to be sure it's good to go. I will enjoy the stuff in the Run and Measure PR anyway.

daniellowell · 2020-06-11T14:58:14Z

Ok, let's have this one next to merge.
We need some reviews though!

DrizztDoUrden · 2020-06-11T15:02:28Z

Sure

atamazov

Oh no 🤦

src/solver/conv_hip_implicit_gemm_v4.cpp

TejashShah · 2020-06-11T18:11:15Z

src/solver/conv_hip_implicit_gemm_v4r4_gen_xdlops.cpp

+    else
+    {
+        result.invoker_factory = [](const std::vector<Kernel>& kernels) {
+            return [=](const Handle& handle, const boost::any& primitve_params) {


SetTensor is missing for fp32. Please take a look at the deleted line 4212 in convolutionocl.cpp file in this PR

Thank you, will fix that.

I wonder how it passed tests.

It didn't won in your tests. This issue leads to correctness issues.

I mean there are long tests which should test something?

It seems like this solver is a new iGemm that produces much more "universal" kernels (like Winograd, so that one kernel fits many problem configs) but the cost is performance drop. So it is quite possible that it never wins in our CI tests.

/cc @daniellowell

Right, what would be interesting to have is a Find mode that also does verification. A self-testing feature.

Interesting idea 🔥

Actually we can make it so right now. The driver could register callbacks in the library. The library should invoke callback when Solvers are being evaluated, after each Invok'ation. The driver verifies output buffer. Done. Ha.

src/solver/conv_hip_implicit_gemm_v4r4_gen_xdlops_wrw_fp32.cpp

atamazov

Please throw in MakeImplGemmDataInvokerFactory() if ctx.direction.IsBackwardWrW() is true.

src/solver/conv_hip_implicit_gemm_v4r4_xdlops.cpp

alexandraBara · 2020-06-18T00:11:55Z

src/solver/conv_hip_implicit_gemm_v4.cpp

+    else
+    {
+        result.invoker_factory = [](const std::vector<Kernel>& kernels) {
+            return [=](const Handle& handle, const boost::any& primitve_params) {


I know im knit-picking but are you trying to say 'primitive_params' instead of primitve_params? throughout

Yeah, thank you. I guess I should install a spellchecker for the VS xD

Good catch 👁️

DrizztDoUrden · 2020-06-18T15:36:43Z

@atamazov I have fixed the missing invoker

atamazov · 2020-06-18T16:42:39Z

I see, thanks. Will re-test soon. Besides, develop is currently blocked for merging due to CI issues, @daniellowell is working of resolving those.

daniellowell · 2020-06-19T17:52:08Z

I merged develop into this branch. It should pass the CI. Final reviews please.

…kers

daniellowell · 2020-06-29T15:19:38Z

@atamazov @alexandraBara Let's move this PR forward.

atamazov · 2020-06-29T19:32:08Z

Just finished rigorous testing session, collecting results...

@alexandraBara Please free to ask @DrizztDoUrden about details of design & implementation. We would like to share knowledge with anyone who wants. Questions make this easier for us.

atamazov

LGTM!

outdated

atamazov · 2020-06-29T19:49:15Z

🌀 Testing results

No performance or correctness regressions among 93 FP32 and 93 FP16 configs, Radeon VII, ROCm 3.5. Both Normal Find and Immediate modes examined.

JehandadKhan · 2020-06-29T21:01:55Z

@alexandraBara Please free to ask @DrizztDoUrden about details of design & implementation. We would like to share knowledge with anyone who wants. Questions make this easier for us.

Can we get a design document ?

DrizztDoUrden · 2020-06-29T23:10:46Z

@JehandadKhan On what specifically? This pr is about WrW igemm invokers, which are 99% copy-paste from old calling code from conv...ocl.cpp
Do you want a manual on how to make an invoker?

atamazov · 2020-06-30T00:16:40Z

@JehandadKhan

Can we get a design document ?

Basic info can be found at #216. We plan to further elaborate explanations using the questions coming from interested individuals.

Vasilii Filippov added 3 commits May 21, 2020 17:19

igemm WrW invokers

6ceaa5e

Updated WrW igemm find to invokers

22532d8

format

4be3d2f

DrizztDoUrden self-assigned this May 21, 2020

Vasilii Filippov added 4 commits May 22, 2020 10:04

Fixed missing invoker

489b580

Merge remote-tracking branch 'origin/develop' into ddu/impl-gemm-invo…

21409b5

…kers

const tidy fixes

60658bb

Merge remote-tracking branch 'origin/develop' into ddu/impl-gemm-invo…

f0960c1

…kers

atamazov added enhancement value_high labels Jun 10, 2020

atamazov requested review from atamazov and daniellowell June 10, 2020 15:17

daniellowell requested review from TejashShah, zjing14 and alexandraBara June 10, 2020 19:58

atamazov approved these changes Jun 11, 2020

View reviewed changes

TejashShah suggested changes Jun 11, 2020

View reviewed changes

src/solver/conv_hip_implicit_gemm_v4.cpp Show resolved Hide resolved

TejashShah suggested changes Jun 11, 2020

View reviewed changes

src/solver/conv_hip_implicit_gemm_v4r4_gen_xdlops_wrw_fp32.cpp Outdated Show resolved Hide resolved

atamazov suggested changes Jun 11, 2020

View reviewed changes

DrizztDoUrden commented Jun 11, 2020

View reviewed changes

src/solver/conv_hip_implicit_gemm_v4r4_xdlops.cpp Show resolved Hide resolved

Vasilii Filippov added 3 commits June 11, 2020 22:26

Made data igemm invoker factory to fail on WrW

7ab501e

Fixed missing SetTensor

7153b68

Removed redundant SetTensor

6a12f0f

atamazov mentioned this pull request Jun 11, 2020

Refactor new Invokers (better structurize code) #282

Open

alexandraBara previously requested changes Jun 18, 2020

View reviewed changes

Fixed primitve_params typo

95d64c1

DrizztDoUrden dismissed TejashShah’s stale review via 95d64c1 June 18, 2020 00:30

Missing invoker

32e7ba7

This comment has been minimized.

Sign in to view

atamazov mentioned this pull request Jun 18, 2020

[driver] Verify all found Solutions #300

Open

daniellowell requested review from alexandraBara, atamazov and TejashShah June 19, 2020 17:51

TejashShah previously approved these changes Jun 19, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/develop' into ddu/impl-gemm-invo…

3a19178

…kers

DrizztDoUrden dismissed TejashShah’s stale review via 3a19178 June 23, 2020 14:56

DrizztDoUrden force-pushed the ddu/impl-gemm-invokers branch from 8e1c802 to 3a19178 Compare June 23, 2020 14:56

Merge remote-tracking branch 'origin/develop' into ddu/impl-gemm-invo…

01027b6

…kers

DrizztDoUrden mentioned this pull request Jun 29, 2020

Invoker auto-tune #203

Merged

atamazov approved these changes Jun 29, 2020

View reviewed changes

daniellowell merged commit 2cea40b into develop Jun 30, 2020

DrizztDoUrden deleted the ddu/impl-gemm-invokers branch September 9, 2020 12:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

igemm WrW invokers #233

igemm WrW invokers #233

DrizztDoUrden commented May 21, 2020 •

edited

Loading

ghost commented May 21, 2020 •

edited by ghost

Loading

daniellowell commented Jun 10, 2020

DrizztDoUrden commented Jun 11, 2020 •

edited

Loading

daniellowell commented Jun 11, 2020

DrizztDoUrden commented Jun 11, 2020

atamazov left a comment •

edited

Loading

TejashShah Jun 11, 2020

DrizztDoUrden Jun 11, 2020

atamazov Jun 11, 2020

DrizztDoUrden Jun 11, 2020 •

edited

Loading

atamazov Jun 11, 2020

DrizztDoUrden Jun 11, 2020

atamazov Jun 11, 2020

daniellowell Jun 11, 2020

atamazov Jun 11, 2020

atamazov Jun 11, 2020 •

edited

Loading

atamazov left a comment

alexandraBara Jun 18, 2020

DrizztDoUrden Jun 18, 2020

atamazov Jun 18, 2020

DrizztDoUrden commented Jun 18, 2020

atamazov commented Jun 18, 2020

This comment has been minimized.

daniellowell commented Jun 19, 2020

This comment has been minimized.

daniellowell commented Jun 29, 2020

atamazov commented Jun 29, 2020

atamazov left a comment

atamazov commented Jun 29, 2020

JehandadKhan commented Jun 29, 2020

DrizztDoUrden commented Jun 29, 2020

atamazov commented Jun 30, 2020

igemm WrW invokers #233

igemm WrW invokers #233

Conversation

DrizztDoUrden commented May 21, 2020 • edited Loading

ghost commented May 21, 2020 • edited by ghost Loading

👉 View analysis in DeepCode’s Dashboard | Configure the bot

daniellowell commented Jun 10, 2020

DrizztDoUrden commented Jun 11, 2020 • edited Loading

daniellowell commented Jun 11, 2020

DrizztDoUrden commented Jun 11, 2020

atamazov left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DrizztDoUrden Jun 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atamazov Jun 11, 2020 • edited Loading

Choose a reason for hiding this comment

atamazov left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DrizztDoUrden commented Jun 18, 2020

atamazov commented Jun 18, 2020

This comment has been minimized.

daniellowell commented Jun 19, 2020

This comment has been minimized.

daniellowell commented Jun 29, 2020

atamazov commented Jun 29, 2020

atamazov left a comment

Choose a reason for hiding this comment

atamazov commented Jun 29, 2020

🌀 Testing results

JehandadKhan commented Jun 29, 2020

DrizztDoUrden commented Jun 29, 2020

atamazov commented Jun 30, 2020

DrizztDoUrden commented May 21, 2020 •

edited

Loading

ghost commented May 21, 2020 •

edited by ghost

Loading

DrizztDoUrden commented Jun 11, 2020 •

edited

Loading

atamazov left a comment •

edited

Loading

DrizztDoUrden Jun 11, 2020 •

edited

Loading

atamazov Jun 11, 2020 •

edited

Loading